[PATCH eac] Add support for a Citation child on Structure

gvandevelde guillaume.vandevelde at logilab.fr
Tue Sep 3 11:14:11 CEST 2019


On 9/3/19 10:51 AM, Frank Bessou wrote:
>
>
> On 03/09/2019 09:54, Katia Saurfelt wrote:
>> # HG changeset patch
>> # User Guillaume Vandevelde <gvandevelde at logilab.fr>
>> # Date 1565106079 -7200
>> #      Tue Aug 06 17:41:19 2019 +0200
>> # Node ID 1eefef56ddfb04337ddf1ce29a3e5843c9a0c026
>> # Parent  529f93fa0fee289de55b2c6fea3639a049725107
>> # Available At http://hg.logilab.org/review/cubes/eac
>> #              hg pull http://hg.logilab.org/review/cubes/eac -r 
>> 1eefef56ddfb
>> Add support for a Citation child on Structure
>
> The test 'test_parse_FRAD033_EAC_00001' is failing 
> (https://jenkins.logilab.org/job/cubicweb-eac/197/).
> It seems that this failure has been introduced in a previous changeset.
> Looking at what it does, it seems that this many little updates are 
> needed whenever an entity or relation is added.
>
> A solution would be to stop checking the value of the extids in this 
> test.
> An other solution is to split this test in several more targeted 
> tests. Only impacted tests would need to be updated.
> Replacing this test by a snapshot test could problably also make it 
> easier to maintain?
> There are probably other ways to solve this though. :)
>
>
The thing is that this test should either block for all the comparison 
on the set of extids, because of the random orders,

either let them all pass. I investigated the problem and I saw that not 
all the entities was compared in this test,

and I wanted to fix the root of the problem instead of just patching the 
tests. A quick fix could be to sort the

extid before the comparison. It worked but I felt like I was missing 
something.

I'll make a fix so that the tests will pass and will think of it when 
I'll have the time.





More information about the saem-devel mailing list