[PATCH eac] Add support for a Citation child on Structure
frank.bessou at logilab.fr
Tue Sep 3 10:51:04 CEST 2019
On 03/09/2019 09:54, Katia Saurfelt wrote:
> # HG changeset patch
> # User Guillaume Vandevelde <gvandevelde at logilab.fr>
> # Date 1565106079 -7200
> # Tue Aug 06 17:41:19 2019 +0200
> # Node ID 1eefef56ddfb04337ddf1ce29a3e5843c9a0c026
> # Parent 529f93fa0fee289de55b2c6fea3639a049725107
> # Available At http://hg.logilab.org/review/cubes/eac
> # hg pull http://hg.logilab.org/review/cubes/eac -r 1eefef56ddfb
> Add support for a Citation child on Structure
The test 'test_parse_FRAD033_EAC_00001' is failing
It seems that this failure has been introduced in a previous changeset.
Looking at what it does, it seems that this many little updates are
needed whenever an entity or relation is added.
A solution would be to stop checking the value of the extids in this test.
An other solution is to split this test in several more targeted tests.
Only impacted tests would need to be updated.
Replacing this test by a snapshot test could problably also make it
easier to maintain?
There are probably other ways to solve this though. :)
More information about the saem-devel