[PATCH 1 of 3 eac] Add support for <chronList> under <biogHist> tag

Denis Laxalde denis.laxalde at logilab.fr
Tue Jul 9 18:05:13 CEST 2019


Guillaume Vandevelde a écrit :
> # HG changeset patch
> # User Guillaume Vandevelde <gvandevelde at logilab.fr>
> # Date 1560762819 -7200
> #      Mon Jun 17 11:13:39 2019 +0200
> # Node ID 8f92f8fb2ede33e2c0ec2956fc9d435a5987188c
> # Parent  c6719ba14ca67516c6f2bd932fe562c2a593e376
> # Available At http://hg.logilab.org/review/cubes/eac
> #              hg pull http://hg.logilab.org/review/cubes/eac -r 8f92f8fb2ede
> Add support for <chronList> under <biogHist> tag
> 
> Build a new Event entities as child of the History entity.
> 
> Added as a new entity for handling the case of multiples events under a <biogHist> tag.
> Modified the `add_citation_for` decorator so it can handle any child appending.
> Modified the History child creation and concatenation so it can use this system.

This patch is mixing to things: introduction of a functional change (add
support for <chronList> tag) and a refactoring (introduction of an
abstract decorator add_child_for). So there really needs to be two
changesets.

Also, I recommend not changing the name of add_citations_for decorator
because this is useless and not doing this will ensure that all client
code using it will remain the same (thus minimizing review work).



More information about the saem-devel mailing list