Fwd: Re: [PATCH eac] remove noqa in tests and auto pep8 compliancy

gvandevelde guillaume.vandevelde at logilab.fr
Mon Aug 12 17:16:47 CEST 2019




-------- Forwarded Message --------
Subject: 	Re: [PATCH eac] remove noqa in tests and auto pep8 compliancy
Date: 	Mon, 12 Aug 2019 16:56:30 +0200
From: 	gvandevelde <gvandevelde at logilab.fr>
To: 	Denis Laxalde <denis.laxalde at logilab.fr>




On 8/12/19 4:52 PM, Denis Laxalde wrote:
> Guillaume Vandevelde a écrit :
>> # HG changeset patch
>> # User Guillaume Vandevelde <gvandevelde at logilab.fr>
>> # Date 1565615025 -7200
>> # Mon Aug 12 15:03:45 2019 +0200
>> # Node ID e0a1b6871316311ad9d774c0a5302e60c57d4591
>> # Parent 0b61fbb4f0a7995c7dcc5adeb80d497a67099b05
>> # Available At http://hg.logilab.org/review/cubes/eac
>> # hg pull http://hg.logilab.org/review/cubes/eac -r e0a1b6871316
>> remove noqa in tests and auto pep8 compliancy
>>
>> diff -r 0b61fbb4f0a7 -r e0a1b6871316 test/test_dataimport.py
>> --- a/test/test_dataimport.py Tue Jul 30 17:31:37 2019 +0200
>> +++ b/test/test_dataimport.py Mon Aug 12 15:03:45 2019 +0200
>> @@ -91,20 +91,20 @@
>> 'start_date': set([datetime.date(1800, 1, 1)]),
>> 'end_date': set([datetime.date(2099, 1, 1)]),
>> 'agent_kind': set(['agentkind/authority']),
>> - 'record_id': set(['FRAD033_EAC_00001']),
>> - },
>> - ),
>> + 'record_id': set(['FRAD033_EAC_00001'])
>> + },
>> + ),
> What's the point of all these changes? The code was already
> pep8-compliant here AFAICT.
>
> That's a lot of diffs to read...
The noqa made it pep8 compliant, but after removing the last noqa there 
was 90+ flake8 errors.
>> ('EACOtherRecordId', _gen_extid(),
>> {'eac_other_record_id_of': set(['FRAD033_EAC_00001']),
>> 'value': set([u'1234']),
>> - },
>> - ),
>> + },
>> + ),
>> ('EACOtherRecordId', _gen_extid(),
>> {'eac_other_record_id_of': set(['FRAD033_EAC_00001']),
>> 'value': set([u'ABCD']),
>> 'local_type': set([u'letters']),
>> - },
>> - ),
>> + },
>> + ),
>> ('EACSource', _gen_extid(),
>> {'source_agent': set(['FRAD033_EAC_00001']),
>> 'title': set([u'1. Ouvrages imprimés...']),
> [snip]
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cubicweb.org/pipermail/saem-devel/attachments/20190812/ee67e835/attachment-0184.html>


More information about the saem-devel mailing list