[PATCH saem_ref v2] Add a test demonstrating that ARK identifiers are not unique overall

Frank Bessou frank.bessou at logilab.fr
Mon Feb 19 09:45:01 CET 2018



On 16/02/2018 16:14, Denis Laxalde wrote:
> # HG changeset patch
> # User Denis Laxalde <denis.laxalde at logilab.fr>
> # Date 1518510957 -3600
> #      Tue Feb 13 09:35:57 2018 +0100
> # Node ID d934ae52b79d3f27c319687aafca525fde76efdb
> # Parent  4a200f4623e28e2729c07d23cf62772d852ca007
> # Available At http://hg.logilab.org/review/cubes/saem_ref
> #              hg pull http://hg.logilab.org/review/cubes/saem_ref -r d934ae52b79d
> # EXP-Topic ark/unique-overall
> Add a test demonstrating that ARK identifiers are not unique overall
>
> diff --git a/test/unittest_schema.py b/test/unittest_schema.py
> --- a/test/unittest_schema.py
> +++ b/test/unittest_schema.py
> @@ -48,6 +48,15 @@ class SchemaConstraintsTC(CubicWebTC):
>       configcls = PostgresApptestConfiguration
>       assertValidationError = testutils.assertValidationError
>   
> +    def test_ark_unique_overall(self):
> +        # Demonstrate that we can create two entities with the same ARK
> +        # identifier, this is a bug.
> +        with self.admin_access.repo_cnx() as cnx:
> +            authority = testutils.authority_with_naa(cnx)
> +            agent = cnx.create_entity('Agent', name=u'bob', authority=authority)
> +            cnx.create_entity('ConceptScheme', ark=agent.ark)
> +            cnx.commit()
> +

Wouldn't it be better to have a failing test and then make it pass (by 
fixing the bug) ?. #tdd

>       def test_published_constraint_on_contact_point(self):
>           """ create two agents: one published P and one not published N.
>               create one OU and check that interface will only show P that can become its
>



More information about the saem-devel mailing list