[PATCH 3 of 8 compound V2] Make CloneAction abstract

Denis Laxalde denis.laxalde at logilab.fr
Fri Mar 3 10:26:12 CET 2017


Sylvain Thenault a écrit :
> # HG changeset patch
> # User Sylvain Thénault <sylvain.thenault at logilab.fr>
> # Date 1488530671 -3600
> #      Fri Mar 03 09:44:31 2017 +0100
> # Node ID 41dcce2866f1932b1b2c231494d6832572ef9852
> # Parent  0ccdfb18031a8b063dbf9b96af64d19db2bfd57b
> Make CloneAction abstract
>
> we don't want it to appear auto-magically for every IClonable entities
>
> diff --git a/test/data/entities.py b/test/data/entities.py
> --- a/test/data/entities.py
> +++ b/test/data/entities.py
[...]
> +# In any case IClonable entities want default copy disabled since it wont handle
> +# composite relations by default.
>  actions.CopyAction.__select__ &= ~adaptable('IClonable')
>

This is a bit contradictory with your intent to not have things happen
"auto-magically". Somebody may want both shallow copy and clone, who knows?
Just nitpicking, this patch is fine :)



More information about the saem-devel mailing list