[PATCH 2 of 4 compound] Rework default cloning UI features

Sylvain Thénault sylvain.thenault at logilab.fr
Wed Mar 1 12:06:34 CET 2017



Le 01/03/2017 à 11:23, Denis Laxalde a écrit :
> Sylvain Thenault a écrit :
>> # HG changeset patch
>> # User Sylvain Thénault <sylvain.thenault at logilab.fr>
>> # Date 1488349780 -3600
>> #      Wed Mar 01 07:29:40 2017 +0100
>> # Node ID eddc207dda229ac1323f7885b4b1b57b93fcc988
>> # Parent  4d02c64534c7e907f0464b0c87733391a483af7b
>> Rework default cloning UI features
>>
>> * make CloneAction abstract, we don't want it to appear
>> auto-magically for every
>>   IClonable entities,
>>
>> * backport NoWarningCopyFormView from saem_ref,
>>
>> * extract part of CloneAction.url into linkto_clone_url_params
>> function and test
>>   it,
>>
>> * enhance translation,
>>
>> * more docstrings / comments.
>
> I'm afraid I don't follow your motivation. I though you did not want the
> clone action at ? You should explain in the "backout" changeset why you
> changed your mind at least.
>
> For this one, I think it should be splitted (more or less following the
> bullet list above).
>
my original motivation was to avoid automagical 'clone' action appearing
on the only condition of being adaptable to IClonable. This is still
done, but only by making the CloneAction abstract, not by removing code,
which I rather enhanced because I ended needing the feature originaly in
saem_ref only also in sherpa/seda, so I reconsidered the related code
location.

-- 
Sylvain Thénault, LOGILAB, Paris (01.45.32.03.12) - Toulouse (05.62.17.16.42)
Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations
Développement logiciel sur mesure:       http://www.logilab.fr/services
CubicWeb, the semantic web framework:    http://www.cubicweb.org



More information about the saem-devel mailing list