[PATCH 2 of 4 compound] Rework default cloning UI features

Denis Laxalde denis.laxalde at logilab.fr
Wed Mar 1 11:23:54 CET 2017


Sylvain Thenault a écrit :
> # HG changeset patch
> # User Sylvain Thénault <sylvain.thenault at logilab.fr>
> # Date 1488349780 -3600
> #      Wed Mar 01 07:29:40 2017 +0100
> # Node ID eddc207dda229ac1323f7885b4b1b57b93fcc988
> # Parent  4d02c64534c7e907f0464b0c87733391a483af7b
> Rework default cloning UI features
>
> * make CloneAction abstract, we don't want it to appear auto-magically for every
>   IClonable entities,
>
> * backport NoWarningCopyFormView from saem_ref,
>
> * extract part of CloneAction.url into linkto_clone_url_params function and test
>   it,
>
> * enhance translation,
>
> * more docstrings / comments.

I'm afraid I don't follow your motivation. I though you did not want the
clone action at ? You should explain in the "backout" changeset why you
changed your mind at least.

For this one, I think it should be splitted (more or less following the
bullet list above).



More information about the saem-devel mailing list