[PATCH 2 of 2 eac] [entities] allow controlling export of recordId and otherRecordId

Denis Laxalde denis.laxalde at logilab.fr
Tue Feb 28 10:18:57 CET 2017


Sylvain Thénault a écrit :
>
>
> Le 28/02/2017 à 09:58, Denis Laxalde a écrit :
>> Sylvain Thénault a écrit :
>>> I think the first one could be pruned by simply
>>> providing a custome AuthorityRecord entity class in saem_ref, that
>>> override the record_id and other_record_ids property. That would be
>>> simple and consistent.
>>
>> I've been thinking about that but resisted to suggest because I wasn't
>> comfortable with overriding a property from schema...
>>
> I still prefer that other adding weird dedicated methods/properties to
> the exporter. In the context of saem_ref where this behaviour is
> specified, it seems to be acceptable.
>

The method I suggested is not weird, it would simply complement existing
(and numerous) _element() methods in the EAC exporter class.

Also, in general, I think that multiple definitions of entity classes in
distinct cubes do not compose very well as you have to take care of
inheritance. Here we have an adapter, why not using it (adapters compose
well)?



More information about the saem-devel mailing list