please review '[server.source.native] exceptions should never pass silently'

Laurent Peuch cortex at worlddomination.be
Thu Jan 9 15:21:04 CET 2020


On Thu, Jan 09, 2020 at 09:59:08AM +0100, Nicolas Chauvat wrote:
> On Wed, Jan 08, 2020 at 04:43:40PM +0100, Laurent Peuch wrote:
> > > On Thu, Dec 19, 2019 at 05:46:46AM +0100, Laurent Peuch wrote:
> > > > LGTM but we might want to add the traceback here, from my experience
> > > > when you actually wants to fix the bug, the exception alone is rarely
> > > > enough.
> > > 
> > > Would https://hg.logilab.org/users/nchauvat/cubicweb/rev/56039b68c449
> > > be better ?
> > 
> > I got "filtered revision '56039b68c449' (not in 'served' subset)" when
> > looking at the link, have you maybe rewrite this changeset?
> 
> Probably. It is now https://hg.logilab.org/users/nchauvat/cubicweb/rev/d57598e42c90

> Do you know of a better way to write this ? I do not like that much
> the fact that I used a StringIO in there.

You can use traceback.format_exc which will return a string directly:
https://docs.python.org/3/library/traceback.html#traceback.format_exc

Otherwise LGTM :)

-- 

Laurent Peuch -- Bram



More information about the cubicweb-devel mailing list