please review '[server.source.native] exceptions should never pass silently'

Laurent Peuch cortex at worlddomination.be
Wed Jan 8 16:43:40 CET 2020


On Thu, Dec 19, 2019 at 12:04:26PM +0100, Nicolas Chauvat wrote:
> On Thu, Dec 19, 2019 at 05:46:46AM +0100, Laurent Peuch wrote:
> > LGTM but we might want to add the traceback here, from my experience
> > when you actually wants to fix the bug, the exception alone is rarely
> > enough.
> 
> Would https://hg.logilab.org/users/nchauvat/cubicweb/rev/56039b68c449
> be better ?

I got "filtered revision '56039b68c449' (not in 'served' subset)" when
looking at the link, have you maybe rewrite this changeset?

> I tried to limit the traceback to 2 frames to avoid flooding the logs.
> 
> Do you know of a better way to write this ? I do not like that much
> the fact that I used a StringIO in there.
> 
> -- 
> Nicolas Chauvat
> 
> logilab.fr - services en informatique scientifique et gestion de connaissances  

-- 

Laurent Peuch -- Bram



More information about the cubicweb-devel mailing list