[PATCH 1 of 2 3.27] Backed out changeset c69421aece24

Philippe Pepiot philippe.pepiot at logilab.fr
Tue Feb 11 10:24:13 CET 2020


# HG changeset patch
# User Philippe Pepiot <philippe.pepiot at logilab.fr>
# Date 1581412818 -3600
#      Tue Feb 11 10:20:18 2020 +0100
# Branch 3.27
# Node ID 50db521e3e53395f93a8a1bdcbd8c5da231361d0
# Parent  50122959acbc5461abeb9a54573f7248f75b0f6a
# Available At https://hg.logilab.org/review/cubicweb
#              hg pull https://hg.logilab.org/review/cubicweb -r 50db521e3e53
Backed out changeset c69421aece24

This is not compatible with python 3.5 and we want to support python 3.5 with cubicweb 3.27

diff --git a/cubicweb/server/hook.py b/cubicweb/server/hook.py
--- a/cubicweb/server/hook.py
+++ b/cubicweb/server/hook.py
@@ -522,8 +522,8 @@ class Hook(AppObject):
     """
     __select__ = enabled_category()
     # set this in derivated classes
+    category = None
     events: Union[None, Tuple[str], Tuple[str, str]] = None
-    category: Union[None, str] = None
     order = 0
     # stop pylint from complaining about missing attributes in Hooks classes
     eidfrom = eidto = entity = rtype = repo = None
diff --git a/cubicweb/web/action.py b/cubicweb/web/action.py
--- a/cubicweb/web/action.py
+++ b/cubicweb/web/action.py
@@ -32,7 +32,6 @@ special view (with `self._cw.build_url(.
 Many examples are available in :mod:`cubicweb.web.views.actions`.
 """
 
-from typing import Optional
 
 from cubicweb import _
 
@@ -49,7 +48,7 @@ class Action(AppObject):
     __registry__ = 'actions'
     __select__ = match_search_state('normal')
     order = 99
-    category: Optional[str] = 'moreactions'
+    category = 'moreactions'
     # actions in category 'moreactions' can specify a sub-menu in which they should be filed
     submenu = None
 




More information about the cubicweb-devel mailing list