[Cubicweb] Patches for 3.19.6

David Douard david.douard at logilab.fr
Wed Nov 26 21:38:53 CET 2014


On 11/26/2014 07:22 PM, Christophe de Vienne wrote:
> Hi,

Hi Christophe,

I've been considering these patches for inclusion in 3.19.6, but 

> I see that cw 3.19.6 is almost ready in the repository.
> 
> Could the following patches be included ?
> 
> - http://www.cubicweb.org/patch/4451240
aka "[devtools][pg] Cleanup connections before dropping the db." make unittest_postgres fail here:

ERROR:  column pg_stat_activity.pid does not exist at character 29
STATEMENT:  SELECT pg_terminate_backend(pg_stat_activity.pid) FROM pg_stat_activity WHERE pg_stat_activity.datname = 'tmpdb' AND pg_stat_activity.pid <> pg_backend_pid();


> - http://www.cubicweb.org/patch/4452259

looks painless but being on the top of the former. However, I've grafted it and I get:

ERROR: test_attr_weight (unittest_postgres.PostgresFTITC)
----------------------------------------------------------------------
Traceback (most recent call last)
  File "/home/david/hg/grshells/grshell-jpl/logilab/common/testlib.py", line 515, in quiet_run
    func(*args, **kwargs)
  File "/home/david/hg/grshells/grshell-jpl/cubicweb/devtools/testlib.py", line 580, in setUp
    self._init_repo()
  File "/home/david/hg/grshells/grshell-jpl/cubicweb/devtools/testlib.py", line 421, in _init_repo
    db_handler.build_db_cache(self.test_db_id, self.pre_setup_database)
  File "/home/david/hg/grshells/grshell-jpl/cubicweb/devtools/__init__.py", line 502, in build_db_cache
    self.backup_database(test_db_id)
  File "/home/david/hg/grshells/grshell-jpl/cubicweb/devtools/__init__.py", line 345, in backup_database
    backup_data = self._backup_database(db_id)
  File "/home/david/hg/grshells/grshell-jpl/cubicweb/devtools/__init__.py", line 677, in _backup_database
    self._repo.turn_repo_off()
AttributeError: 'NoneType' object has no attribute 'turn_repo_off'

> - http://www.cubicweb.org/patch/4601337

I wanted to have a closer look a this later patch, since it looks to me quite a big hammer for the poor dev that do always run tests (who said on NFS?)... In fact, I need a bit more of context here, since I've never seen the error described in the ticket. 

I was about to publish the 3.19.6, so for the 2 former patches, if you can provide me new versions that do not kill my tests, I'll integrate them...

Cheers,

David

  
 
> Thanks,
> 
> Christophe
> _______________________________________________
> Cubicweb mailing list
> Cubicweb at lists.cubicweb.org
> http://lists.cubicweb.org/mailman/listinfo/cubicweb
> 

-- 

David DOUARD		 LOGILAB
Directeur du département Outils & Systèmes

+33 1 45 32 03 12	 david.douard at logilab.fr
+33 1 83 64 25 26	 http://www.logilab.fr/id/david.douard

Formations - http://www.logilab.fr/formations
Développements - http://www.logilab.fr/services
Gestion de connaissances - http://www.cubicweb.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: david_douard.vcf
Type: text/x-vcard
Size: 302 bytes
Desc: not available
URL: <http://lists.cubicweb.org/pipermail/cubicweb/attachments/20141126/5ad4eda6/attachment-0273.vcf>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.cubicweb.org/pipermail/cubicweb/attachments/20141126/5ad4eda6/attachment-0273.sig>


More information about the Cubicweb mailing list