[Cubicweb] Review on cubicweb.org and logilab.org

David Douard david.douard at logilab.fr
Fri Nov 28 10:12:49 CET 2014


Hi list,

sorry I forgot to mention it here, but with the upgrade to cubicweb-vcreview 1.3 on our forges, the review process has changed a bit.

Newly created Patch entities (ie. 'new' draft changesets pushed to the repositories) are NOT entering the review process in "pending-review" state, but in "in-progress". You must explicitely ask for review.

We provide some tools to be able to ask review from your mercurial repository in soon-to-be-released logilab-devtool 0.23 

 https://www.logilab.org/project/logilab-devtools/0.23.0

To summer the process, 

- ensure you have ndg-httpsclient (https://pypi.python.org/pypi/ndg-httpsclient or apt-get install python-ndg-httpsclient)
- ensure you have cwclientlib installed (https://www.cubicweb.org/project/cwclientlib or apt-get install python-cwclientlib) 
- ensure you have the hgext/jpl mercurial extension activated in your ~/.hgrc (provided by logilab-devtools)
- ensure you have created an AuthToken (on each forge), eg. following these links

    https://www.logilabb.org/add/AuthToken
    https://www.cubicweb.org/add/AuthToken

  and be sure the "enabled" checkbox is activated. The AuthToken "id" is the identifier of the token and can be anything you want (eg. something like "<login> token")
  It will generate a secret token (named 'token')

- add a section in the repository's .hg/hgrc 

  [lglb]
  forge-url = https://www.logilab.org/
  auth-mech = signedrequest
  auth-token = <login> token # the AuthToken 'id'
  auth-secret = <secret token> # the generated AuthToken 'token'

or 

  [lglb]
  forge-url = https://www.cubicweb.org/
  auth-mech = signedrequest
  auth-token = <login> token # the AuthToken 'id'
  auth-secret = <secret token> # the generated AuthToken 'token'


Then you may be able to do stuff like:

  david at perseus:[cubicweb:cubicweb]/logilab/common$ hg show-review -r "draft() and ::." 
  https://www.logilab.org/277378  [pending-review]
  [ureports] write unicode not bytes (closes #277372)

  https://www.logilab.org/280886  [pending-review]
  [pytest] fix TestSuite.run wrapper (closes #280806)

  https://www.logilab.org/278874  [pending-review]
  [deprecation] fix class_renamed() on old-style classes
  david at perseus:[cubicweb:cubicweb]/logilab/common$ hg ask-review -r 4c174136fcff
  [OK]

or, so list comments and tasks reviewers may have attached to patches:

  david at perseus:[cubicweb:cubicweb]/logilab/common$ hg tasks -r "draft() and ::."

  [date] Fix utcdatetime https://www.logilab.org/280798 (in-progress)

  [TODO] no need for explicit inclusion of the pytz code here (https://www.logilab.org/280891)
  juste depend on pytz and go


   
Note: one odd with this new process is the fact that when you push a new draft changeset to the repository, you cannot ask review for it immediately, since the forge must first import this new changeset and create Patch from it. It's not very long (few 10s of seconds depending on the activity on the application), but...

-- 

David DOUARD		 LOGILAB
Directeur du département Outils & Systèmes

+33 1 45 32 03 12	 david.douard at logilab.fr
+33 1 83 64 25 26	 http://www.logilab.fr/id/david.douard

Formations - http://www.logilab.fr/formations
Développements - http://www.logilab.fr/services
Gestion de connaissances - http://www.cubicweb.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: david_douard.vcf
Type: text/x-vcard
Size: 302 bytes
Desc: not available
URL: <http://lists.cubicweb.org/pipermail/cubicweb/attachments/20141128/67edb38a/attachment-0272.vcf>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.cubicweb.org/pipermail/cubicweb/attachments/20141128/67edb38a/attachment-0272.sig>


More information about the Cubicweb mailing list