[PATCH 21 of 24 yams V2] [fix] correct keyword arguments for call

Laurent Peuch cortex at worlddomination.be
Wed Mar 4 15:17:57 CET 2020


# HG changeset patch
# User Laurent Peuch <cortex at worlddomination.be>
# Date 1580318124 -3600
#      Wed Jan 29 18:15:24 2020 +0100
# Node ID a27d8e2f0f45a0521afc1eb48c1b471b9fe99839
# Parent  b1204623450c0b39830db8946df5a0d58abc3ea9
# Available At https://hg.logilab.org/users/lpeuch/yams
#              hg pull https://hg.logilab.org/users/lpeuch/yams -r a27d8e2f0f45
# EXP-Topic type_annotations
[fix] correct keyword arguments for call

I'm not 100% sure about those modification, here is the type signature of schema2dot:

    def schema2dot(schema=None, outputfile: Optional[str] = None, skiptypes=(),
                   visitor=None, prophdlr=None, size=None) -> Any:

Also I'm really suspecting that this code is dead code since no one has
launched it since year to raise this bug.

diff --git a/yams/tools.py b/yams/tools.py
--- a/yams/tools.py
+++ b/yams/tools.py
@@ -135,9 +135,8 @@ def schema_image() -> int:
         out = tmp_file.name
 
     schema2dot.schema2dot(schema, out,  # size=size,
-                          skiprels=("identity",),
-                          skipentities=("Person", "AbstractPerson", "Card", "AbstractCompany",
-                                        "Company", "Division"))
+                          skiptypes=("Person", "AbstractPerson", "Card", "AbstractCompany",
+                                     "Company", "Division"))
 
     if viewer:
         p = Popen((viewer, out))



More information about the cubicweb-devel mailing list