[PATCH 2 of 2] [debugtoolbar] Make SQL and RQL tables sortable

Laurent Peuch cortex at worlddomination.be
Thu Mar 19 09:44:47 CET 2020


Hello,

This series LGTM, I think we can merge it :)

Thx for it!

Side note, maybe it would make sens to add pDebugSortable to other
tables too?

On Wed, Mar 18, 2020 at 05:12:57PM +0100, Simon Chabot wrote:
> # HG changeset patch
> # User Simon Chabot <simon.chabot at logilab.fr>
> # Date 1584023931 -3600
> #      Thu Mar 12 15:38:51 2020 +0100
> # Node ID eca7ed0d224bb7a9e7a3de1fbec1b19641e5d9b5
> # Parent  747190dd8020fe3c28bc852bd18cf5cc3bb0e99f
> # Available At https://hg.logilab.org/review/cubicweb/
> #              hg pull https://hg.logilab.org/review/cubicweb/ -r eca7ed0d224b
> # EXP-Topic debugtoolbar_fixes
> [debugtoolbar] Make SQL and RQL tables sortable
> 
> It's usefull to sort query by duration for instance.
> 
> diff -r 747190dd8020 -r eca7ed0d224b cubicweb/pyramid/debug_toolbar_templates/rql.dbtmako
> --- a/cubicweb/pyramid/debug_toolbar_templates/rql.dbtmako	Thu Mar 12 15:37:59 2020 +0100
> +++ b/cubicweb/pyramid/debug_toolbar_templates/rql.dbtmako	Thu Mar 12 15:38:51 2020 +0100
> @@ -1,4 +1,4 @@
> -<table id="rql-table" class="table table-striped table-condensed">
> +<table id="rql-table" class="pDebugSortable table table-striped table-condensed">
>      <thead>
>          <tr>
>              <th class="table-col-1">#</th>
> diff -r 747190dd8020 -r eca7ed0d224b cubicweb/pyramid/debug_toolbar_templates/sql.dbtmako
> --- a/cubicweb/pyramid/debug_toolbar_templates/sql.dbtmako	Thu Mar 12 15:37:59 2020 +0100
> +++ b/cubicweb/pyramid/debug_toolbar_templates/sql.dbtmako	Thu Mar 12 15:38:51 2020 +0100
> @@ -1,4 +1,4 @@
> -<table id="sql-table" class="table table-striped table-condensed">
> +<table id="sql-table" class="pDebugSortable table table-striped table-condensed">
>      <thead>
>          <tr>
>              <th class="table-col-index">#</th>

-- 

Laurent Peuch -- Bram



More information about the cubicweb-devel mailing list