[PATCH 1 of 2] Drop useless ConstraintInsertionTC

Nicola Spanti nicola.spanti at logilab.fr
Wed Sep 11 16:37:42 CEST 2019


I published the first one. The second one looks good to me too, but I 
prefer that someone else reviews too.

Le 11/09/2019 à 16:12, Philippe Pepiot a écrit :
> # HG changeset patch
> # User Philippe Pepiot <philippe.pepiot at logilab.fr>
> # Date 1568194625 -7200
> #      Wed Sep 11 11:37:05 2019 +0200
> # Branch 3.26
> # Node ID 0481ece35cb20dba3a331190ec68b847bbca743d
> # Parent  1b4e32301f143371ec17ae363bd7ff6c347fefa7
> # Available At https://hg.logilab.org/review/cubicweb
> #              hg pull https://hg.logilab.org/review/cubicweb -r 0481ece35cb2
> Drop useless ConstraintInsertionTC
> 
> This test does nothing and is here from the begining of repo history.
> 
> Now it raise an error "TypeError: Skipped expected string as 'msg' parameter, got 'SkipTest' instead. Perhaps you meant to use a mark?"
> 
> Just drop it.
> 
> diff --git a/cubicweb/devtools/test/unittest_dbfill.py b/cubicweb/devtools/test/unittest_dbfill.py
> --- a/cubicweb/devtools/test/unittest_dbfill.py
> +++ b/cubicweb/devtools/test/unittest_dbfill.py
> @@ -110,12 +110,5 @@ class ValueGeneratorTC(TestCase):
>           self.assertEqual(self.person_valgen.generate_attribute_value({}, 'description', 12),
>                             u'yo')
>   
> -
> -class ConstraintInsertionTC(TestCase):
> -
> -    def test_writeme(self):
> -        self.skipTest('Test automatic insertion / Schema Constraints')
> -
> -
>   if __name__ == '__main__':
>       unittest_main()
> 



More information about the cubicweb-devel mailing list