[PATCH 2 of 7] [cubicweb-ctl] backport --loglevel option of pyramid to all instance commands

Noé Gaumont noe.gaumont at logilab.fr
Thu Sep 5 09:11:29 CEST 2019


I should have spent more time on it :/
There is indeed no changes on options…

I was mislead by the i18ninstance_instance function that has been moved 
from class to instance.

On 04/09/2019 17:48, Laurent Peuch wrote:
> On Wed, Sep 04, 2019 at 09:22:18AM +0200, Noé Gaumont wrote:
>> Hi,
>>
>> Thanks for this patch (and the whole series).
>>
>> Could you explain why you moved ShellCommand.options  from class attributes
>> to instance attribute?
>> I did not see any obvious reason (but did not spend time on it).
> I'm sorry but I don't see where I did that in that patch or in any
> other patches of the series :x can you point me the line please?
>
>> On 01/09/2019 04:06, Laurent Peuch wrote:
>>> # HG changeset patch
>>> # User Laurent Peuch <cortex at worlddomination.be>
>>> # Date 1558454897 -7200
>>> #      Tue May 21 18:08:17 2019 +0200
>>> # Node ID b533d93f38ee32f597c830adf70f661abeddb706
>>> # Parent  a63c93f27994cbb440a0431c1809166216eaa712
>>> [cubicweb-ctl] backport --loglevel option of pyramid to all instance commands
>>>
>>> diff --git a/cubicweb/cwctl.py b/cubicweb/cwctl.py
>>> --- a/cubicweb/cwctl.py
>>> +++ b/cubicweb/cwctl.py
>>> @@ -690,16 +710,14 @@ class RecompileInstanceCatalogsCommand(I
>>>       """
>>>       name = 'i18ninstance'
>>> -    @staticmethod
>>> -    def i18ninstance_instance(appid):
>>> +    def i18ninstance_instance(self, appid):
>>>           """recompile instance's messages catalogs"""
>>> -        config = cwcfg.config_for(appid)
>>> -        config.quick_start = True  # notify this is not a regular start
>>> -        repo = config.repository()
>>> -        if config._cubes is None:
>>> +        self.cwconfig.quick_start = True  # notify this is not a regular start
>>> +        repo = self.cwconfig.repository()
>>> +        if self.cwconfig._cubes is None:
>>>               # web only config
>>> -            config.init_cubes(repo.get_cubes())
>>> -        errors = config.i18ncompile()
>>> +            self.cwconfig.init_cubes(repo.get_cubes())
>>> +        errors = self.cwconfig.i18ncompile()
>>>           if errors:
>>>               print('\n'.join(errors))



More information about the cubicweb-devel mailing list