[PATCH] [cubicweb-ctl] respect sys.exit status code when abording a command

Laurent Peuch cortex at worlddomination.be
Fri Jul 12 12:18:28 CEST 2019


On Fri, Jul 12, 2019 at 09:55:56AM +0200, Denis Laxalde wrote:
> Laurent Peuch a écrit :
> > # HG changeset patch
> > # User Laurent Peuch <cortex at worlddomination.be>
> > # Date 1558453191 -7200
> > #      Tue May 21 17:39:51 2019 +0200
> > # Node ID 3f15afaa8a0741f7eeaffe99315f5a26d944792d
> > # Parent  3305dedd33faccba22cf67abc7c01ba702a8f950
> > # EXP-Topic improve-cli
> > [cubicweb-ctl] respect sys.exit status code when abording a command
> 
> I don't really understand this patch. It seems that it fixes a problem
> introduced in the previous changeset? If not, can you explain the actual
> problem in the commit message?

Ah no, this is totally unrelated, I just came across this behavior
that was already in CW
https://hg.logilab.org/master/cubicweb/file/d1b5fd6129bd/cubicweb/cwctl.py#l161
where is always overwrite the return code event if the code does a
"SystemExit(anotherCode)" at some point which seems wrong.

I need to check if I haven't mixed a bit this patch and the previous
one, that's possible, it's been a long time since I've made them
(before writing test), sorry :/

> In any case, I like the first patch in the series but I'm not sure if
> this is applicable without this one.

-- 

Laurent Peuch -- Bram



More information about the cubicweb-devel mailing list