[PATCH] [py3] Decode subprocess stdout in toolsutils.show_diffs()

Philippe Pepiot philippe.pepiot at logilab.fr
Wed Jun 6 16:18:47 CEST 2018


On 06/06/2018, Denis Laxalde wrote:
> # HG changeset patch
> # User Denis Laxalde <denis.laxalde at logilab.fr>
> # Date 1528278975 -7200
> #      Wed Jun 06 11:56:15 2018 +0200
> # Node ID 4d8268ef1fb713f793508d73fef19cb40986adba
> # Parent  aa999699e5047da7512ececd8ead42a2f1b15e4b
> # Available At https://hg.logilab.org/review/cubicweb
> #              hg pull https://hg.logilab.org/review/cubicweb -r 4d8268ef1fb7
> # EXP-Topic py3
> [py3] Decode subprocess stdout in toolsutils.show_diffs()
> 
> On Python 3, subprocess' pipes are bytes stream so we must decode them
> before printing. Without this change, diff of configuration files (e.g.
> all-in-one.conf as displayed upon instance upgrade) will rendered as a
> single line on Python 3.

Applied, thanks!


More information about the cubicweb-devel mailing list